[Sugar-devel] [PATCH sugar-toolkit] Remove hippo from naming alert

[Sascha Silbe]

Excerpts from Daniel Drake's message of 2011-09-17 19:37:48 +0200:

> Reimplement the favorite icon as a ToggleButton, and use standard
> boxes, entrys and textviews for the other aspects.

Thanks for the patch! The sooner we can get rid of HippoCanvas the
better. :)

I haven't tried it out to verify the layout, but the code changes look
sane to me.

Reviewed-By: Sascha Silbe <silbe at activitycentral.com>

[src/sugar/activity/namingalert.py]
[NamingAlert._create_text_view()]
> +        #scrolled_window.set_border_width(30)

Leftover from testing?

[NamingAlert.__keep_cb()]
> +        text_buffer = self._tags.get_buffer()
> +        bounds = text_buffer.get_bounds()
> +        new_tags = text_buffer.get_text(bounds[0], bounds[1])

How about start, end instead of bounds?

> +        text_buffer = self._description.get_buffer()
> +        bounds = text_buffer.get_bounds()
> +        new_description = text_buffer.get_text(bounds[0], bounds[1])

Dto.

Sascha

-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110926/51e33c0e/attachment-0001.pgp>