[Sugar-devel] [PATCH sugar-toolkit] Don't put event box in toplevel window

Marco Pesenti Gritti marco at marcopg.org
Sat Sep 17 09:18:33 EDT 2011

On 17 September 2011 12:47, Daniel Drake <dsd at laptop.org> wrote:
> From: Simon Schampijer <simon at schampijer.de>
> Remove an unnecessary toplevel widget.
> This event box was originally added by Marco "to make it easier
> to take screenshot of the canvas area only" (7f731457c2) but we're
> unsure why this is, and it doesn't seem to be needed for our current
> screenshot-taking mechanism. Screenshots continue to work fine after
> removing this.

If I remember correctly this was necessary because we was getting
snapshots from the X server and we needed to ensure we had an XWindow
in the canvas for that to work. It seems like we are using the gtk
client side mechanism for snapshots now, so that should not be
necessary anymore.

The patch looks good to me.


More information about the Sugar-devel mailing list