[Sugar-devel] New toolbar in Memorize

[Gonzalo Odiard]

Here is a first patch implementing the proposed changes.
This patch, does not include the change to synchronize the model in play and
create mode,
or the change in the saving procedure, because I think is better do it in a
separated patch.

Gonzalo

On Mon, Sep 12, 2011 at 9:01 AM, Gonzalo Odiard <gonzalo at laptop.org> wrote:

> Thanks a lot!
> I will work on it now.
>
> Gonzalo
>
> On Sun, Sep 11, 2011 at 9:29 PM, Gary Martin <garycmartin at googlemail.com>wrote:
>
>> Hi Gonzalo,
>>
>> On 9 Sep 2011, at 18:44, Gonzalo Odiard wrote:
>>
>> 2011/9/9 manuel quiñones <manuq at laptop.org>
>>
>> As Simon said, I think that the cog button should toggle to edit mode
>> directly, no need for a "click to edit" toggle button in the
>> subtoolbar.  As it is a toggle, we should disable activation when
>> hovering on it (I think this has to be done globally for al toggles in
>> a toolbox, maybe a Sugar change?).
>>
>>
>> I think this behavior will be inconsistent with all the other activities.
>> We discussed this a lot when implemented  Record toolbars.
>>
>>
>> I've been working with Simon on the Memorize toolbar here at Paris Sugar
>> Camp #2, hopefully you'll find this consistent :)
>>
>> Below are the two mockups, the first shows the Memorize toolbar in Play
>> mode. The activity toolbar is now the only toolbutton with a secondary
>> toolbar. Start new game icon (Memorize icon with the spark badge) is
>> insensitive when the game is in a fresh unused state, and once you start to
>> play and turn over cards Start new becomes sensitive (so the game can be
>> reset – the mockup below shows the initial game state has already been
>> modified). Manual saving and loading of games has been removed:
>>
>>
>>
>> The second mockup shows the toolbar in Edit mode. The game playing
>> features are made insensitive, the edit feature made sensitive, and the edit
>> canvas is drawn:
>>
>>
>>
>>
>> We should replace the current "click to edit" button with a "New game"
>> button to start from scratch.  The icon can be the one for "click to
>> edit".
>>
>>
>> We should change the icon for "restart game", maybe using the sparkle
>> alone?  Something in the line of this?
>>
>> http://dev.laptop.org/~manuq/memorize_design/memorize_restart_button.png
>>
>>
>> Hmm, I don't like it. May be we can use a single big sparkle. And change
>> the icon in other similar cases,
>> like implode.
>>
>>
>> The mockups above show radio switching between the Play mode (using the
>> standard media play icon) and the Edit mode (the cog icon), with the Start
>> new game (reset currently loaded game) functionality using the Memorize icon
>> with the spark badge. It is far away from the Activity icon to avoid
>> confusion, and is made sensitive once a game's state has been modified.
>>
>>
>>
>> For the clear game button, we may use the icon 'X' inside a square
>> fill, as in Gary's mockup here:
>>
>> http://wiki.sugarlabs.org/go/File:Memorize_edit_toolbar_view.png
>>
>>
>> Yes, this is true. I will replace it
>>
>>
>> Yes, I've used this icon (originally from Paint) in the above mockups,
>> clicking it should clear the current game cards (button is sensitive in edit
>> mode only).
>>
>>
>>
>> Another thing: I expect that if I edit a game and then come back to
>> play mode, I get the modified game reloaded.
>>
>>
>> Good point. May be, can be updated when we save the game.
>> If the user restart the game must use the new updated tiles.
>>
>>
>> Editing the cards and then playing should be as seamless as possible. Note
>> that saving and loading have been removed completely from Memorize, the game
>> card set would be kept in its Journal entry. If a user wants to make a new
>> separate set of cards based on an existing set, they would use the new
>> Journal --> Duplicate feature, and then resume that and edit it as needed.
>>
>> Switching from Edit mode to Play mode would automatically start a new game
>> (with your new card changes), but only if the user has modified the cards
>> (clicking the edit cog icon part way through a game and then clicking play
>> again without card changes should carry on with the existing game).
>>
>>
>>
>> I would like to discuss this topics in the design meeting next Monday.
>>
>>
>> I'll try to stay logged into irc tomorrow as much as possible during the
>> day (before my flight back to the UK), so please do ping so we can talk over
>> any unclear details. The Memorize toolbar rework has been really tricky, it
>> seems to have so many unusual edge cases!
>>
>> Regards,
>> --Gary
>>
>> Ok, thanks by the review!
>>
>> Regards,
>>
>> 2011/9/8 Simon Schampijer <simon at schampijer.de>:
>> > On 09/08/2011 01:33 PM, Gonzalo Odiard wrote:
>> >>
>> >> Simon also complained about how is implemented the change of mode to
>> >> create/play.
>> >> Have the Design Team any other idea?
>> >>
>> >> Gonzalo
>> >
>> > To phrase out my 'complain':) In the edit sub-toolbar you have to click
>> on
>> > the edit button at the far left to start editing and the edit canvas is
>> > shown. To get out of the edit mode you have to click on that toggle
>> button
>> > again. It took me a while to figure that out. Maybe the button should
>> > change, based on the mode it is in. Also you can expand/shrink the
>> toolbar
>> > while the full edit view is open which is a bit confusing.
>> >
>> > Another option: I thought to display the full edit view when you click
>> on
>> > the edit button, Gonzalo was worried that this would cause issues when
>> you
>> > hover over the button (maybe we disable hovering in that case?).
>> >
>> > Regards,
>> >   Simon
>> >
>>
>>
>>
>> --
>> .. manuq ..
>>
>>
>>
>> _______________________________________________
>> Sugar-devel mailing list
>> Sugar-devel at lists.sugarlabs.org
>> http://lists.sugarlabs.org/listinfo/sugar-devel
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110913/b8de59d5/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Memorize_play_mode_edit_ghost.png
Type: image/png
Size: 12748 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110913/b8de59d5/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Memorize_edit_mode_play_ghost.png
Type: image/png
Size: 13032 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110913/b8de59d5/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Implementation-of-new-toolbar.patch
Type: text/x-patch
Size: 80891 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110913/b8de59d5/attachment-0001.bin>