[Sugar-devel] [PATCH] Browse: tabs usability improved

[Simon Schampijer]

Ahh, sorry Manuel Idid not check the palette. Hmm, I think the Browser should
not hold a reference on the tabbed view. I would add a signal to the Browser
class to bubble that information up to the tabbed view. Then you can add a
public method to the Browser (from where to send the signal) so the palette can
access it. What do you think?

 
Regards,
   Simon
 
 

"manuel quiñones" <manuq at laptop.org> hat am 10. September 2011 um 16:35
geschrieben:

> El día 10 de septiembre de 2011 03:51, Simon Schampijer
> <simon at schampijer.de> escribió:
> > On 09/10/2011 05:15 AM, manuel quiñones wrote:
> >>
> >> El día 9 de septiembre de 2011 20:28, Simon Schampijer
> >> <simon at schampijer.de>  escribió:
> >>>
> >>> On 09/09/2011 04:48 AM, manuel quiñones wrote:
> >>>>
> >>>> Hi Simon,
> >>>>
> >>>> I'm resending the patch with the fixes you noticed.
> >>>
> >>> Hi,
> >>>
> >>> Manuel, looks great. I have only a few smaller cleanups (unused imports
> >>> etc)
> >>> and there is one traceback left when you resume a session. I would
> >>> suggest
> >>> the following:
> >>>
> >>> - push your patch (you can add my ack flag)
> >>
> >> Good!  But I don't have rights to git push in Browse repo, can you do
> >> the commit?
> >
> > Ok, done - and pushed the pylint fix-ups.
>
> Thanks!
>
> > Can you pull and see if everything
> > is working as expected?
>
> "Follow link in new tab" is not working.  You can see why I passed the
> tabbed_view object to the browser objects constructor method.
>
> Cheers,
>
> >
> > Regards,
> >   Simon
> >
>
>
>
> --
> .. manuq ..