[Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

[Simon Schampijer]

On 10/17/2011 08:38 PM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of 2011-10-17 11:07:13 +0200:
>
>> - powerpc is not a popular Sugar platform to make an enormous effort for
>> supporting it
>
> I wouldn't consider anything we discussed an "enormous effort". With
> that attitude PowerPC would never be a viable platform. Catch-22.

I knew people would jump on that. The original patch would not have had 
any impact on Sugar running on powerpc, just that the version displayed 
in the CP would not have a meaning. I could have lived with that. Still, 
I am waiting for reports of people running Sugar on powerpc...And I 
don't think *this* is a blocker for them.

>> - displaying all of the string on both cases (OLPC/powerpc) will likely
>> confuse people used to the old humanized string that is displayed at current
>>
>> - the string does always start with "CL": CL1 for XO-1, CL1B for XO-1.5,
>> CL2 for XO-1.75, to differentiate we can do the following:
>>
>> if: string.startswith('CL') string[6:13]
>> else: display all of the string
>
> Sounds good enough to me. We don't even need the length check as
> foo[6:13] will simply give an empty string if foo is too short. Might be
> good to add a comment to that effect, though.

I will send a new full patch.

Regards,
    Simon