[Sugar-devel] [PATCH sugar] Make sure that we have a connection before we set our properties SL #3119

Sascha Silbe sascha-ml-reply-to-2011-4 at silbe.org
Sat Oct 8 16:23:06 EDT 2011


Excerpts from Simon Schampijer's message of 2011-10-07 19:47:34 +0200:
> The issue here is that we di not have a connection yet, when
                            ^ did
> the name owner changes. It is safer to listen to the connection
> watcher when a connection is added (which was the original code).
> Tested as working fine in gabble and salut.

I can't claim I fully grok the code, but it's at least making _some_
sense and your patch makes it simpler, so:

Acked-By: Sascha Silbe <silbe at activitycentral.com>

Let's just hope there wasn't a reason for it to be so complicated
before. :)

Sascha

-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20111008/3d79f640/attachment.pgp>


More information about the Sugar-devel mailing list