[Sugar-devel] [PATCH] Update alpha according to filter after events in neighborhoodview icons - SL #3091

Simon Schampijer simon at schampijer.de
Fri Oct 7 12:08:41 EDT 2011

On 09/26/2011 02:29 PM, Sascha Silbe wrote:
> Excerpts from godiard's message of 2011-09-22 21:11:42 +0200:
> [src/jarabe/desktop/networkviews.py]
>> @@ -149,6 +149,7 @@ class WirelessNetworkView(CanvasPulsingIcon):
>>           self._update_state()
>>           self._update_icon()
>>           self._update_badge()
>> +        self._update_color()
> [...]
> Thanks for the patch! However it looks more like a workaround than a
> real fix.
> Why do _all_ AP icons get updated when the state of at most two
> connections changes? Why does the alpha value get reset when the icons
> are updated?
> Neither the patch description nor the ticket nor digging into the source
> answer the above questions.
> Sascha

The WirelessNetworkView listens on the State signal of the device, so it 
is true that all the icons are updated when the device state changes. 
This could be optimized in general.

Gonzalo's patch does not do anything different than the existing code. 
So, I am happy with his patch. As it is a regression over 0.92 I am good 
with pushing it as well to the 0.94 branch.


More information about the Sugar-devel mailing list