[Sugar-devel] [DESIGN] Pippy export buttons

[Rafael Ortiz]

2011/10/6 Manuel Quiñones <manuq at laptop.org>

> Thanks Gonzalo and everyone for the feedback!
>
> El día 6 de octubre de 2011 14:02, Gonzalo Odiard <gonzalo at laptop.org>
> escribió:
> > Thanks Manuel, looks great.
> > A few comments about the patch:
> > * There are lines longer than 80 cols.
> > * You should not use  _("Export") + ' ' + _("As Pippy Document")
> > but _("Export as Pippy Document")
> > Nobody can assure in other languages the order will be the same.
>
> You are right, I though that making like I did would not raise new
> translations, but I was wrong.
>
> > * I think we should hide the keepbutton, because is hidden in sugar 0.94
> but
> > this activity
>
> OK, done in the new patch, attached in the bug tracker.
>
>
Pushed, should be in next version thanks.


>  > can be used with older Sugar versions, but this should be confirmed with
> the
> > activity maintainer.
> > Gonzalo
>
> Thanks!
>
> --
> .. manuq ..
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20111007/cc7e3f05/attachment.html>