[Sugar-devel] [DESIGN] Pippy export buttons
Manuel Quiñones
manuq at laptop.org
Thu Oct 6 21:18:32 EDT 2011
Thanks Gonzalo and everyone for the feedback!
El día 6 de octubre de 2011 14:02, Gonzalo Odiard <gonzalo at laptop.org> escribió:
> Thanks Manuel, looks great.
> A few comments about the patch:
> * There are lines longer than 80 cols.
> * You should not use _("Export") + ' ' + _("As Pippy Document")
> but _("Export as Pippy Document")
> Nobody can assure in other languages the order will be the same.
You are right, I though that making like I did would not raise new
translations, but I was wrong.
> * I think we should hide the keepbutton, because is hidden in sugar 0.94 but
> this activity
OK, done in the new patch, attached in the bug tracker.
> can be used with older Sugar versions, but this should be confirmed with the
> activity maintainer.
> Gonzalo
Thanks!
--
.. manuq ..
More information about the Sugar-devel
mailing list