[Sugar-devel] [PATCH v2] Simple NetworkManager-0.9 port

[Daniel Drake]

On Mon, Nov 14, 2011 at 6:38 AM, Simon Schampijer <simon at schampijer.de> wrote:
>> diff --git a/extensions/cpsection/modemconfiguration/model.py
>> b/extensions/cpsection/modemconfiguration/model.py
>> index 1e83c44..8b8ef05 100755
>> --- a/extensions/cpsection/modemconfiguration/model.py
>> +++ b/extensions/cpsection/modemconfiguration/model.py
>> @@ -14,68 +14,88 @@
>>  # along with this program; if not, write to the Free Software
>>  # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301
>>  US
>>
>> -import gconf
>> +import logging
>>
>> -from jarabe.model.network import GSM_USERNAME_PATH, GSM_PASSWORD_PATH, \
>> -                                 GSM_NUMBER_PATH, GSM_APN_PATH,
>> GSM_PIN_PATH, \
>> -                                 GSM_PUK_PATH
>> +import dbus
>> +import gtk
>>
>> +from jarabe.model import network
>>
>> -def get_username():
>> -    client = gconf.client_get_default()
>> -    return client.get_string(GSM_USERNAME_PATH) or ''
>>
>> +def get_connection():
>> +    return network.find_gsm_connection()
>
> Can we make this private? The 'get_*' 'set_*' are listed in the command line
> tool.

Doing that would break the undo functionality that Sascha requested. I
don't see a sensible way to satisfy both systems under the current
design of the sugar control panel.

>> -        interface_props.Get(_NM_DEVICE_IFACE, 'State',
>> -
>>  reply_handler=self.__get_device_state_reply_cb,
>> -
>>  error_handler=self.__get_device_state_error_cb)
>
> What was the reasoning here, to not getting the state anymore and get it
> when we have the ActiveAccessPoint? Any issue we are fixing?

See my earlier comment on this code. In context it should make sense.
Now that we support network setup outside of sugar we need to know the
active AP before we process state.

All other feedback incorporated.

Daniel