[Sugar-devel] [PATCH 2/2] disabling become root button
sascha-ml-reply-to-2011-2 at silbe.org
Fri May 20 17:29:31 EDT 2011
Excerpts from Rafael Ortiz's message of Thu May 19 18:52:59 +0200 2011:
> Temporaly Disabling become root button on terminal activity
> avoiding problems reported SL#2756 and #2597, also in merge request on gitorious
CC'ing Gary and Walter to discuss the UI side of this.
As discussed in both tickets [1,2] we might want to get rid of this
button permanently - at least in its current form. It's dangerous
(kills the currently running process(es)) and just a shorthand for
While getting rid of the button without any replacement would make root
access less easy to discover, I'd argue that without a minimal
introduction the shell functionality is equally "hard" to discover. The
same minimal introduction (/etc/motd?) could mention "sudo -i".
> @@ -86,17 +86,17 @@ class TerminalActivity(activity.Activity):
> # Add a button that will be used to become root easily.
> - root_button = ToolButton('activity-become-root')
> - root_button.set_tooltip(_('Become root'))
> + #root_button = ToolButton('activity-become-root')
> + #root_button.set_tooltip(_('Become root'))
Please just remove the lines. If we want to bring them back later, we
can just revert the patch. That's what a VCS is for after all.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 494 bytes
Desc: not available
More information about the Sugar-devel