[Sugar-devel] [PATCH sugar] Cache the XO palette in the Home View, part of #2726

Simon Schampijer simon at schampijer.de
Thu Mar 31 11:56:11 EDT 2011


On 03/31/2011 08:35 AM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of Tue Mar 29 17:41:26 +0200 2011:
>
>> Hmm, the default behavior is that the Invoker does cache the palette
>> [1].
>
> OK, good point. So as a pure bug fix, your current patch is more in line
> with the existing code. Therefore:
>
> Acked-by: Sascha Silbe<silbe at activitycentral.com>

Thanks for the review, pushed to master and sucrose-0.92:

http://git.sugarlabs.org/sugar/mainline/commit/98d61eebf274a3d2aea4f5c924e30bc74967307e

http://git.sugarlabs.org/sugar/mainline/commit/aa889e81c7e8bd9a9df5c7fc27432a7335d2d905

> We might want to consider changing the default behaviour some time in
> the future, however (provided there are measurable performance
> benefits).

If there is evidence, I am open to a suggested patch :)

Regards,
    Simon



More information about the Sugar-devel mailing list