[Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

[Simon Schampijer]

On 03/31/2011 08:27 AM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of Wed Mar 23 15:56:54 +0100 2011:
>
> [src/jarabe/model/neighborhood.py]
>> +        params_needing_reconnect = account.UpdateParameters(
>> +            {'server': server,
>> +             'account': account_id,
>> +             'register': True},
>> +            dbus.Array([], 's'), dbus_interface=ACCOUNT)
>
> The dictionary fits on a single line, increasing the amount of code that
> fits on the screen and thus making it easier to grok the code when
> viewing it on an XO.
>
>> +        params_needing_reconnect = account.UpdateParameters(
>> +            {'jid': account_id},
>> +            dbus.Array([], 's'), dbus_interface=ACCOUNT)
>
> Similarly, all parameters fit on a single line.

I did this to match the rest of the code of that file. I am ok with both 
ways, so I went away with moving it on one line.

> Acked-by: Sascha Silbe<silbe at activitycentral.com>
>
>
> Thanks for the patch!
>
> Sascha
>

Pushed to master and sucrose-0.92:
http://git.sugarlabs.org/sugar/mainline/commit/e385144b67404de98ddcd74b99e4745bbe0d7834

Thanks for the review,
    Simon