[Sugar-devel] [PATCH sugar] Fix inviting from friends view OLPC #10767

Simon Schampijer simon at schampijer.de
Tue Mar 29 11:55:04 EDT 2011


On 03/25/2011 03:19 PM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of Thu Mar 24 21:52:04 +0100 2011:
>
>> Add the contact_id and the account information to the buddymodel used in
>> the group view. We do not store it in the friends model as the id and the
>> account information may vary.
>
> Why do we need those two when adding a friend from the UI, but not when
> loading the friends list from disk (jarabe.model.friends.Friends.load())?
>
> Sascha

We need it in both occasions when we do invite a friend to an activity 
[1]. What I meant is that I do not want to store this information on 
disk as I think that it is information that can change and therefore 
should not be stored. When we read the friends information from disk the 
contact_id and account information gets added to the model whenever we 
have it [2].

Regards,
    Simon

[1] 
http://git.sugarlabs.org/sugar/mainline/blobs/master/src/jarabe/view/buddymenu.py#line165
[2] 
http://git.sugarlabs.org/sugar/mainline/blobs/master/src/jarabe/model/friends.py#line57


More information about the Sugar-devel mailing list