[Sugar-devel] [PATCH sugar] Cache the XO palette in the Home View, part of #2726

Simon Schampijer simon at schampijer.de
Tue Mar 29 11:41:26 EDT 2011


On 03/25/2011 04:30 PM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of Thu Mar 24 21:16:32 +0100 2011:
>
>> The patch does cache the palette of the Owner, this has been
>> the behavior before 356641c332d6cc889b265dfc29598004cf37763c. As
>> registering (and therefore the change of the palette) happens
>> rather seldom compared to the change of a buddy palette, I think
>> the Owner palette can be considered to be mostly static
>> and therefore we can cache it.
>
> I'd approach this from a different angle (than the palette being static)
> and prefer the second patch [1] you attached to #2726 [2]: The owner
> palette provides access to functions (My Settings, Register, end
> session) that I don't expect to be used rather often during the lifetime
> of a Sugar session and the palette can easily be reconstructed, so we
> don't need to cache it (thus saving a tiny bit of memory).

Hmm, the default behavior is that the Invoker does cache the palette 
[1]. Currently we do only not cache the buddy palettes (in the 
neighborhood view). I thought the goal was to not have to reconstruct 
the palette when there was no change, which would be the case for most 
of the cases for this palette (you don't connect to a school server that 
often).

Regards,
    Simon

[1] 
http://git.sugarlabs.org/sugar-toolkit/mainline/commit/29582de67f3189d232e170b1e07e9bf34233fb51


More information about the Sugar-devel mailing list