[Sugar-devel] [PATCH sugar] Cache the XO palette in the Home View, part of #2726

Sascha Silbe sascha-ml-reply-to-2011-2 at silbe.org
Fri Mar 25 16:30:36 EDT 2011


Excerpts from Simon Schampijer's message of Thu Mar 24 21:16:32 +0100 2011:

> The patch does cache the palette of the Owner, this has been
> the behavior before 356641c332d6cc889b265dfc29598004cf37763c. As
> registering (and therefore the change of the palette) happens
> rather seldom compared to the change of a buddy palette, I think
> the Owner palette can be considered to be mostly static
> and therefore we can cache it.

I'd approach this from a different angle (than the palette being static)
and prefer the second patch [1] you attached to #2726 [2]: The owner
palette provides access to functions (My Settings, Register, end
session) that I don't expect to be used rather often during the lifetime
of a Sugar session and the palette can easily be reconstructed, so we
don't need to cache it (thus saving a tiny bit of memory).

You can consider this an Ack for your second patch. I trust you to add a
nice description. ;)

BTW: Thanks for all your recent patches!

Sascha

[1] https://bugs.sugarlabs.org/raw-attachment/ticket/2726/no_cache.patch
[2] https://bugs.sugarlabs.org/ticket/2726
-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 500 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110325/fa0263ff/attachment.pgp>


More information about the Sugar-devel mailing list