[Sugar-devel] [PATCH sugar] Nick name in file-transfer palette needs to be a string #10735

[Simon Schampijer]

Pushed with a better description and making it a tuple. 
dad5ad7f4477b84d15705129cd7e97bdbe9457f

Regards,
    Simon

On 03/22/2011 01:24 PM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of Tue Mar 08 22:26:08 +0100 2011:
>
>> Signed-off-by: Simon Schampijer<simon at laptop.org>
>
> How about "Don't put quotes around nick name in file transfer palette
> (OLPC#10735)" as summary?
>
> [src/jarabe/frame/activitiestray.py]
>> -        self.props.secondary_text = _('Transfer from %r') % nick
>> +        self.props.secondary_text = _('Transfer from %s') % nick
>
> For consistency I'd prefer "(nick, )". It also makes it less likely
> that we forget to wrap the value in a tuple if the value is a tuple
> itself. [1]
>
> Acked-By: Sascha Silbe<silbe at activitycentral.com>
>
> Sascha
>
> [1] http://docs.python.org/library/stdtypes.html#id11
>
>
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel