[Sugar-devel] [PATCH sugar] Nick name in file-transfer palette needs to be a string #10735

Sascha Silbe sascha-ml-reply-to-2011-2 at silbe.org
Tue Mar 22 13:24:46 EDT 2011


Excerpts from Simon Schampijer's message of Tue Mar 08 22:26:08 +0100 2011:

> Signed-off-by: Simon Schampijer <simon at laptop.org>

How about "Don't put quotes around nick name in file transfer palette
(OLPC#10735)" as summary?

[src/jarabe/frame/activitiestray.py]
> -        self.props.secondary_text = _('Transfer from %r') % nick
> +        self.props.secondary_text = _('Transfer from %s') % nick

For consistency I'd prefer "(nick, )". It also makes it less likely
that we forget to wrap the value in a tuple if the value is a tuple
itself. [1]

Acked-By: Sascha Silbe <silbe at activitycentral.com>

Sascha

[1] http://docs.python.org/library/stdtypes.html#id11
-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 500 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110322/146b13f1/attachment.pgp>


More information about the Sugar-devel mailing list