[Sugar-devel] [PATCH sugar] Sugar Ad-hoc network: reconnect after suspend SL #2187

[Simon Schampijer]

On 03/02/2011 09:23 AM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of Tue Mar 01 23:53:47 +0100 2011:
>
>> Setting the 'autoconnect' property for the connection
>> will let NM do the reconnection when the device is up. If
>> the Sugar Ad-hoc network is around it will automatically
>> connect to it. The connection is not stored after logging
>> out of Sugar.
>>
>> The autoconnect functionality inside Sugar is still needed
>> for the cases when we log into Sugar, after a timeout we
>> will connect to an exisiting Ad-hoc network or will default
>> to the Sugar Ad-hoc network on channel 1. I increased the
>> timeout to 60 seconds because during testing I found to
>> get more reliable results like that.
>
> Acked-By: Sascha Silbe<silbe at activitycentral.com>
>
>
> [src/jarabe/model/adhoc.py]
>>           self._idle_source = gobject.timeout_add_seconds( \
>> -                self._AUTOCONNECT_TIMEOUT, self.__idle_check_cb)
>> +            self._AUTOCONNECT_TIMEOUT, self.__idle_check_cb)
>
> As you're already at it, please remove the backslash on the first line
> (implicit [1] instead of explicit [2] line joining).
>
> Sascha
>
> [1] http://docs.python.org/reference/lexical_analysis.html#implicit-line-joining
> [2] http://docs.python.org/reference/lexical_analysis.html#explicit-line-joining

Thanks for the review, pushed with taking your comment into account:

582f9df1acbff8c71d897f37a4a4e98d4830fd3f

Regards,
    Simon