[Sugar-devel] [PATCH] Fix for PDF scrolling with Page Up/Page Down.

[manuel quiñones]

El día 30 de junio de 2011 05:40, Simon Schampijer
<simon at schampijer.de> escribió:
> On 06/30/2011 06:32 AM, Manuel Quiñones wrote:
>>
>> We were passing wrong second parameter to the scroll method of
>> evince.View .
>> ---
>>  evinceadapter.py |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/evinceadapter.py b/evinceadapter.py
>> index 3d3350c..3ddcfd4 100644
>> --- a/evinceadapter.py
>> +++ b/evinceadapter.py
>> @@ -228,9 +228,9 @@ class EvinceViewer():
>>          _logger.error('scroll: %s', scrolltype)
>>
>>          if scrolltype == gtk.SCROLL_PAGE_BACKWARD:
>> -            self._view.scroll(gtk.SCROLL_PAGE_BACKWARD, -1)
>> +            self._view.scroll(gtk.SCROLL_PAGE_BACKWARD, horizontal)
>>          elif scrolltype == gtk.SCROLL_PAGE_FORWARD:
>> -            self._view.scroll(gtk.SCROLL_PAGE_FORWARD, 1)
>> +            self._view.scroll(gtk.SCROLL_PAGE_FORWARD, horizontal)
>>          elif scrolltype == gtk.SCROLL_STEP_BACKWARD:
>>              self._scroll_step(False)
>>          elif scrolltype == gtk.SCROLL_STEP_FORWARD:
>
> Thanks for the patch. Looks good to me.
>
> Reviewed-by: Simon Schampijer <simon at laptop.org>
>
>
> Some small formal comments. If the patch fixes a bug, it is good to note
> that in the patch title (i.e. OLPC #10950, SL #123). And it is good to add
> yourself as the signer, like:
>
> Signed-off-by: Manuel Quiñones <manuq at laptop.org>

Thanks for pointing it Simon, I'll do next time.

-- 
.. manuq ..