[Sugar-devel] [PATCH sugar-toolkit] GlibTCPServer: defer shutdown_request to avoid closing the socket too early OLPC #10906

[Simon Schampijer]

On 06/29/2011 02:44 PM, Simon Schampijer wrote:
> From: Daniel Drake<dsd at laptop.org>
>
> In Python 2.7, shutdown_request was added to the BaseServer class and
> TCPServer was adopted to use it instead of close_request in the
> _handle_request_noblock() path.
>
> GlibTCPServer must be adapted to account for this, so that
> shutdown_request is not allowed to prematurely allowed to close the socket,
> in the same way that close_request is ignored.
>
> Fixes collaboration in activities that rely on this mechanism for
> sharing (including ImageViewer and Read)
>
> Signed-off-by: Daniel Drake<daniel at laptop.org>
> Acked-by: Simon Schampijer<simon at laptop.org>
> Tested-by: Gonzalo Odiard<gonzalo at laptop.org>
> Tested-by: Simon Schampijer<simon at laptop.org>


Tested and reviewed, pushed as 
http://git.sugarlabs.org/sugar-toolkit/mainline/commit/10580fc2a73aec1f828a3d8d43489e1d31a670c1

Regards,
     Simon