[Sugar-devel] [PATCH] Browse: Set and restore index in the history - Fix OLPC #10779 / SL #2499

[Rafael Ortiz]

On Sat, Jun 18, 2011 at 11:23 AM, Gonzalo Odiard <gonzalo at laptop.org> wrote:

>
>
> On Sat, Jun 18, 2011 at 8:44 AM, Sascha Silbe <
> sascha-ml-reply-to-2011-3 at silbe.org> wrote:
>
>> Excerpts from Gonzalo Odiard's message of Wed Jun 08 17:04:41 +0200 2011:
>>
>> > To test with multiple tabs, in F14 I needed to replace:
>> >
>> > -        self._disable_multiple_tabs = cairo.cairo_version() >= 10810
>> > +        self._disable_multiple_tabs = cairo.cairo_version() >= 10810 \
>> > +                and cairo.cairo_version() < 11002
>> >
>> > I don't know if is in your plans restore multiple tabs, functionality in
>> > F14,
>> > but the cairo bug is gone.
>>
>> That's great news! I'd appreciate if someone could check which cairo
>> version (at least of those that are shipped by distributions) was the
>> first to fix all the tabbing related bugs (IIRC there were several
>> different bugs) so we can adjust the check accordingly.
>>
>
> Anybody with a F13 or F12 environment?
> I can only confirm the F14 case, and I think the next images from OLPC and
> AC
> will be based in it.
>

Just tested this with a little change under F11
(cairo.cairo_version()=11000), it works, so we can change the patch to

 +        self._disable_multiple_tabs = cairo.cairo_version() >= 10810 \
> +                and cairo.cairo_version() < 11000

Should work for all the posterior F versions.

>
> Gonzalo
>
>
>> We only deactivate the UI for creating new tabs, BTW - they can still be
>> created using JavaScript, which is how I tested your patch.
>>
>> Sascha
>>
>>
The code comment

>  --
>> http://sascha.silbe.org/
>> http://www.infra-silbe.de/
>>
>> _______________________________________________
>> Sugar-devel mailing list
>> Sugar-devel at lists.sugarlabs.org
>> http://lists.sugarlabs.org/listinfo/sugar-devel
>>
>>
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110622/350ae52d/attachment.html>