[Sugar-devel] [PATCH] Display build number at Name Page

[Frederick Grose]

On Wed, Jun 15, 2011 at 10:56 PM, Frederick Grose <fgrose at gmail.com> wrote:

> On Wed, Jun 15, 2011 at 8:28 PM, James Cameron <quozl at laptop.org> wrote:
>
>> On Wed, Jun 15, 2011 at 12:01:55PM -0300, Esteban Bord?n wrote:
>> > This patch show the build number in the name page for first boot (see
>> > attached file). It's very useful to test the correct massive flashing
>> > for technical team.
>>
>> I like it.
>>
>> One small technical change though ...
>>
>> > @@ -86,7 +86,20 @@ class _NamePage(_Page):
>> >                         orientation=hippo.ORIENTATION_HORIZONTAL,)
>> >
>> >          self._intro = intro
>> > +
>> > +        if os.path.exists('/boot/olpc_build'):
>> > +            build_no_path = '/boot/olpc_build'
>> > +        elif os.path.exists('/etc/fedora-release'):
>> > +            build_no_path = '/etc/fedora-release'
>> > +        else:
>> > +            build_no_path = None
>> >
>> > +        if build_no_path:
>> > +            fd = open('/etc/fedora-release', 'r')
>>
>> The line above should open build_no_path rather than
>> '/etc/fedora-release'
>>
>> --
>> James Cameron
>> http://quozl.linux.org.au/
>>
>
> To keep with Sugar's design, it would be good to put the text in gray, and
> in the lower left corner, so as to de-emphasize it in relation to the
> Learner's primary activity on that screen, and to balance the visual weights
> with the '> Next' and '< Back' buttons.
>
>            --Fred
>

Once the particular "massive flashing" protocol has been tested and
debugged, is the information really needed at that point?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110615/21103a8e/attachment.html>