[Sugar-devel] [PATCH sugar-toolkit] Handle DBUS tubes in the activity telepathy client, part of OLPC #10738

[Simon Schampijer]

On 06/07/2011 07:34 PM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of Mon May 30 14:41:59 +0200 2011:
>
>> One part has to claim the interest into the dbus channels, either the
>> Shell or the Activity. Before my patch sharing with dbus tubes did work,
>> since the shell claimed that they would handle the channels, but this
>> had the side effect of ghost invitations. Now I changed the code that
>> the shell only approves invitations and the activity is responsible to
>> handle/claim the channels they are interested in. Etoys (currently still
>> using the presence service) will need to make the same, create a Handler
>> that claims the channels Etoys is interested in [2].
>
> OK, thanks, this makes things a little clearer, though there are still
> one question I can't answer myself yet:
>
> Do we need to change something in sugar-presence-service to make
> activities that still rely on it (like EToys) work after your patches?
> (we'll drop sugar-presence-service in 0.94, but not in 0.92.x)

Hmm, good catch. Etoys is breaking actually if we do not handle the dbus 
tubes in the shell. I would say we go back and handle the channels in 
the shell. The critical part that caused the error described in [1] was 
the approving unrestricted approving in the shell.

Regards,
    Simon

[1] http://dev.laptop.org/ticket/10738