[Sugar-devel] [PATCH sugar] Register with schoolserver: adopt to changes in xmlrpclib for python 2.7 OLPC #10776

[Simon Schampijer]

On 06/07/2011 06:42 PM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of Mon May 23 10:01:01 +0200 2011:
>
>>> I guess we don't need to subclass Transport, but we probably need to
>>> call socket.setdefaulttimeout() during Sugar start-up:
> [...]
>
>> Hmm, yes sounds about right. I don't think we have to do it during sugar
>> startup (not sure about other side-effects), just after the 'else' is
>> fine.
>
> The side effects are exactly the reason I want it to run on start-up.
> That way things will always behave the same, instead of potentially
> breaking in odd ways only after the user has used Register during the
> current session (which is rather hard to diagnose - to the user it's a
> one-time glitch, not reproducible).
>
> Another, less risky idea would be to call socket.setdefaulttimeout(None)
> afterwards (using try-final) to reset the value to the default (no
> timeout).

I think I prefer the second one. So the patch with just that addition?

Simon