[Sugar-devel] [PATCH] removing imports that prevented launching

[Gonzalo Odiard]

Hmmm, sorry, I can't remove BeautifulSoup from epubview.py neither :)
It's used to do text to speach in epub files.

Gonzalo

On Mon, Jun 6, 2011 at 10:14 AM, Gonzalo Odiard <gonzalo at laptop.org> wrote:

> Hi Rafael,
> I can remove the use of BeautifulSoup in epubview.py,
> but in jobs.py is used to search.
> It's strange you can't use it in sugar 0.88, because the import is in the
> initial
> commit from Sayamindu when he added epub suppport, two years ago.
>
> git show 9760c4c9
>
> commit 9760c4c9acdf0ea1cf4c57ded8c65eb4390ca171
> Author: Sayamindu Dasgupta <sayamindu at gmail.com>
> Date:   Tue Jul 21 01:14:46 2009 +0530
>
>     Added epubview from upstream
>
> BeautifulSoup is used in GetBooks too.
>
> Gonzalo
>
>
>
> On Sat, Jun 4, 2011 at 7:22 PM, Rafael Ortiz <rafael at activitycentral.com>wrote:
>
>> removing BeautifulSoup imports that prevented launch,
>> this regression can affect epubview.
>> ---
>>  epubview/epubview.py |    1 -
>>  epubview/jobs.py     |    1 -
>>  2 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/epubview/epubview.py b/epubview/epubview.py
>> index 432c332..cec56c5 100644
>> --- a/epubview/epubview.py
>> +++ b/epubview/epubview.py
>> @@ -22,7 +22,6 @@ import widgets
>>  import os.path
>>  import math
>>  import shutil
>> -import BeautifulSoup
>>
>>  from epub import _Epub
>>  from jobs import _JobPaginator as _Paginator
>> diff --git a/epubview/jobs.py b/epubview/jobs.py
>> index a0b6771..779b69c 100644
>> --- a/epubview/jobs.py
>> +++ b/epubview/jobs.py
>> @@ -23,7 +23,6 @@ import cairo
>>
>>  import math
>>  import os.path
>> -import BeautifulSoup
>>
>>  import epub
>>
>> --
>> 1.7.4.1
>>
>> _______________________________________________
>> Sugar-devel mailing list
>> Sugar-devel at lists.sugarlabs.org
>> http://lists.sugarlabs.org/listinfo/sugar-devel
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110606/ad6b80c6/attachment-0001.html>