[Sugar-devel] [PATCH] Zoom in and out in Terminal

[Rafael Ortiz]

On Fri, Jun 3, 2011 at 9:24 PM, James Cameron <quozl at laptop.org> wrote:

> Yay, my eyes are happy.  I like it.
>
> On Fri, Jun 03, 2011 at 11:12:45PM -0300, Manuel Qui??ones wrote:
> > ---
>
> Missing patch description.  Suggest something like:
>
> - adds a zoom out and zoom in button, with accelerators, which change
>  text font size of the terminal area.  Same accelerators as used by
>  GNOME Terminal.
>
> +1.

> > @@ -425,7 +455,6 @@ class TerminalActivity(activity.Activity):
> >
> >          font = self._get_conf(conf, 'font', 'Monospace')
> >          vt.set_font(pango.FontDescription(font))
> > -
> >          fg_color = self._get_conf(conf, 'fg_color', '#000000')
> >          bg_color = self._get_conf(conf, 'bg_color', '#FFFFFF')
> >          vt.set_colors(gtk.gdk.color_parse(fg_color),
>
> I'm not sure you wanted to remove that blank line.  It seems to help
> with readability.
>
> +1

Tested and works as expected, will be in next release of terminal, good
addition!.


> Reviewed-by: James Cameron <quozl at laptop.org>
>
> --
> James Cameron
> http://quozl.linux.org.au/
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110604/751c6045/attachment.html>