[Sugar-devel] Removal of Activity Keep button

[Simon Schampijer]

On 07/31/2011 05:17 AM, Gonzalo Odiard wrote:
> On Sat, Jul 30, 2011 at 7:30 PM, Rafael Ortiz<rafael at activitycentral.com>wrote:
>
>> On Fri, Jul 29, 2011 at 6:34 PM, Gonzalo Odiard<gonzalo at laptop.org>wrote:
>>
>>> Hi James,
>>> There are no problem, the KeepButton class is not removed, but is not
>>> added by default in the toolbar.
>>> The activities will work ok.
>>>
>>>
>> James, +1.
>>
>> You can remove the code w/o problem, if you don't remove it, the activity
>> won't work but only for sugar>=0.94 (as I understand it from Simon) , this
>> is only for activities that have the keepbutton ''hardcoded'' in the
>> activity toolbar code.
>>
>
>
> Rafael:
> This is not correct.
> The activity will continue working, because the class KeepButton was not
> removed (there are two proposed patches, look at the second)
> In most of the activities, the default Activity Tolbar is used, and in sugar
> 0.94, the KeepButton will not be displayed.
> In a few activities, the developer hidden the button, or used a custom
> toolbar, and we provided patches to resolve them.
> Of course, we did not checked the hundred of activities in ASLO, but only
> the activities included by default in OLPC image,
> then if another activity use the button (or the user is using a old version
> of the activity) the only difference will be
> the KeepButton will be present, but the activity will works ok.
>
> Gonzalo

Right, so the button is only deprecated for now, and usage is 
discouraged. It will be removed in a later version.

Regards,
    Simon