[Sugar-devel] Removal of Activity Keep button

[Rafael Ortiz]

On Fri, Jul 29, 2011 at 6:34 PM, Gonzalo Odiard <gonzalo at laptop.org> wrote:

> Hi James,
> There are no problem, the KeepButton class is not removed, but is not added
> by default in the toolbar.
> The activities will work ok.
>
>
James, +1.

You can remove the code w/o problem, if you don't remove it, the activity
won't work but only for sugar >=0.94 (as I understand it from Simon) , this
is only for activities that have the keepbutton ''hardcoded'' in the
activity toolbar code.



> Gonzalo
>
> On Fri, Jul 29, 2011 at 12:39 PM, James Simmons <nicestep at gmail.com>wrote:
>
>> Rafael,
>>
>> One of my concerns is that the Keep button is useless or misleading for
>> all of my Activities.  That's why I hide it.  I also show how to hide it in
>> my book "Make Your Own Sugar Activities!"  That is why I'd prefer that the
>> Keep button be hidden by default.  Hiding it a second time won't hurt
>> anything, and if someone actually has a use for it they can show it.  Just
>> removing it breaks backward compatibility.  I go to a fair amount of effort
>> to make Activities that support any version of Sugar, including using the
>> new toolbars when they are available.  I don't want students to have to
>> wonder if one of my Activities will work for them.  I know that full
>> backwards compatibility is not possible for every Activity, but if you do
>> Python without components other than GTK it should still be possible.
>>
>> James Simmons
>>
>>
>> On Fri, Jul 29, 2011 at 9:57 AM, Rafael Ortiz <rafael at activitycentral.com
>> > wrote:
>>
>>> Simon, James
>>>
>>> Thanks for pointing out the cases where the activities can fail.
>>>
>>> I think it's all clear for activity devs to follow.
>>>
>>> Recommendation: Remove keep button of all your activities if you have it
>>> on the toolbars code. In order to have compatibility for sugar >=0.94.
>>>
>>> Thanks and cheers.
>>>
>>>
>>>
>>> On Fri, Jul 29, 2011 at 8:15 AM, Simon Schampijer <simon at schampijer.de>wrote:
>>>
>>>> On 07/29/2011 02:54 PM, James Simmons wrote:
>>>>
>>>>> Simon and Rafael,
>>>>>
>>>>> My Activities don't have any use for the Keep button, so they hide it.
>>>>>  As a
>>>>> result, if you just remove the Keep button they'll stop working.  Maybe
>>>>> for
>>>>> backward compatibility keep the button but hide it by default?
>>>>>
>>>>> James Simmons
>>>>>
>>>>> Just to be clear if we remove the keep button from an activity it wont
>>>>> open
>>>>>
>>>>>> in previous sugar versions than 0.94
>>>>>>
>>>>>
>>>> The use of the Keep button will be deprecated for a development cycle,
>>>> only, see [1]. But I would still recommend you to remove the hide the keep
>>>> button from your activity.
>>>>
>>>> Regards,
>>>>   Simon
>>>>
>>>> [1] http://lists.sugarlabs.org/**archive/sugar-devel/2011-July/**
>>>> 032438.html<http://lists.sugarlabs.org/archive/sugar-devel/2011-July/032438.html>
>>>>
>>>
>>>
>>
>> _______________________________________________
>> Sugar-devel mailing list
>> Sugar-devel at lists.sugarlabs.org
>> http://lists.sugarlabs.org/listinfo/sugar-devel
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110730/71058e9e/attachment.html>