[Sugar-devel] [PATCH] Record: icons for the toolbar that replace strings "timer" and "duration"

[Gary Martin]

Hi Manuel,

On 18 Jul 2011, at 14:47, manuel quiñones wrote:

> El día 18 de julio de 2011 09:34, Daniel Drake <dsd at laptop.org> escribió:
>> For OLPC we decided to include this in 11.2.0 even though it hasn't
>> quite passed through the whole process, here is the patch I will use:
>> http://dev.laptop.org/~dsd/20110718/0001-Use-icons-rather-than-strings-in-main-toolbar-for-ti.patch
>> 
>> Thanks for your hard work - almost there!
>> Daniel
>> 
> 
> Thanks Daniel for your insightful feedback.  I'll wait for Gary's comments.

Apologies for the long delay getting back, and thanks for the screen shot! I've also now tried it out with the updated Record in the os874 xo-1 build. Very nice :) I think this works great as a solution to remove the long text. +1 for landing this officially, this is way better than what we previously had.

OK, so now some picky feedback ;)

Option 1. Ideally the icon would only show in the combo widget when it is not currently open, and when a user does click to open the combo, the menu options would be text only (no repeated clock icons for each contained item).

Option 2. The alternative approach (perhaps more gtk combo design friendly) would be to make 3 different icons for each combo (1 star, 2 star, 3 start for the start delay clocks; and small pie wedge, medium pie wedge, large pie wedge for the duration clocks).

--Gary

> Regards,
> 
> -- 
> .. manuq ..
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel