[Sugar-devel] [PATCH sugar] Set the nick name when the buddy properties changes OLPC #10750

[Sascha Silbe]

Excerpts from Simon Schampijer's message of Mon Jul 18 19:51:16 +0200 2011:

> We do get the correct nick information but we did not update
> the buddy because of checking for a wrong property key. I checked
> that in all the cases (alias-change or when we do get the buddy
> information in various ways) the key is
> "CONNECTION_INTERFACE_ALIASING + '/alias'".

Acked-By: Sascha Silbe <silbe at activitycentral.com>

[src/jarabe/model/neighborhood.py]
> @@ -929,8 +929,9 @@ class Neighborhood(gobject.GObject):
>          if 'key' in properties:
>              buddy.props.key = properties['key']
>  
> -        if 'nick' in properties:
> -            buddy.props.nick = properties['nick']
> +        nick_key = CONNECTION_INTERFACE_ALIASING + '/alias'
> +        if nick_key in properties:
> +            buddy.props.nick = properties[nick_key]

How come only the nick name is prefixed by the interface name, but
neither 'color' nor 'key'? Is it because they're custom Sugar
properties? Should they also be prefixed by an interface name and we're
doing something wrong elsewhere?

Sascha

-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 500 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110718/50f62377/attachment.pgp>