[Sugar-devel] [PATCH] Icons for the toolbar that replace strings "timer" and "duration"

[manuel quiñones]

El día 16 de julio de 2011 17:50, Daniel Drake <dsd at laptop.org> escribió:
> Hi Manuel,
>
> Next time please send patches to the activity maintainer in To: (in
> this case this is me) and the sugar-devel list in Cc. Also if you
> mention the activity title in the subject line that is useful. I had
> skipped over this subject line as something that didn't concern me.

Yes Daniel you are right, sorry, I'll do next time.

> What is the state of this patch? Gonzalo suggested that it was ready
> for my review but didn't clarify if this is implementing something
> suggested by the design team, if it has seen their acknowledgement,
> etc.

I have raised the discussion to the list in june with [DESIGN] in the subject:

http://lists.sugarlabs.org/archive/sugar-devel/2011-June/032024.html

I did mockups of how the change may look, and after positive feedback,
I implemented it.

> One comment on the code:
>
>> +class IconComboBox(gtk.ToolItem):
>> +    def __init__(self, icon_filename, **kwargs):
>> +        gobject.GObject.__init__(self, **kwargs)
>
> Is there a reason why you don't call the gtk.ToolItem constructor?

You are right, it should call the parent's constructor.  The reason
the patch is that way is because I started copying ToolComboBox class
from sugar.graphics.toolcombobox module.  I'll update the patch in the
bug tracker.

Thanks for your comments.

-- 
.. manuq ..