[Sugar-devel] [PATCH sugar] Add missing import (follow up of OLPC #10798)

Simon Schampijer simon at schampijer.de
Tue Jul 12 11:22:51 EDT 2011


On 07/04/2011 05:21 PM, Simon Schampijer wrote:
> On 07/01/2011 04:35 PM, Sascha Silbe wrote:
>> This is a fix for a regression introduced by commit
>> 9d0d372 ("Raise alert when trying to send an entry without an associated
>> file OLPC #10798").
>
> Adjusted the description and pushed as:
>
> http://git.sugarlabs.org/sugar/mainline/commit/077521c35f21270033408e09518bf003fb6b25ec
>
>
> Thanks for the review,
> Simon

Gah, bfc725ea04f482cc0aab8bf3c9206f07dd331427 was a stupid commit. I 
know now how I missed the missing import. Since it wrote the patch while 
working on copy-to for the Journal I did mess up the patch. There is 
still an error in there. As fixing that would be too complicated before 
the copy-to patch lands I would vote for reverting the 
bfc725ea04f482cc0aab8bf3c9206f07dd331427 commit, at least on 0.92 on 
master if we land the copy-to patch soon would be ok too, I guess.

Regards,
    Simon


More information about the Sugar-devel mailing list