[Sugar-devel] [PATCH sugar-toolkit] Remove incomplete MANIFEST support

[Gary Martin]

On 5 Jul 2011, at 10:22, Simon Schampijer <simon at schampijer.de> wrote:

> On 07/03/2011 05:54 PM, Sascha Silbe wrote:
>> From: Bernie Innocenti<bernie at codewiz.org>
>> 
>> This incomplete feature contributes to confuse new activity authors and
>> slightly complicates our bundle installation logic.
>> 
>> The day someone finds something useful to do with the MANIFEST
>> specification, we can revert this patch in no time.
>> 
>> Signed-off-by: Bernie Innocenti<bernie at codewiz.org>
>> Tested-by: Bernie Innocenti<bernie at codewiz.org>
>> Tested-by: James Cameron<quozl at laptop.org>
>> Tested-by: Sascha Silbe<silbe at activitycentral.com>
>> Reviewed-by: Sascha Silbe<silbe at activitycentral.com>
>> [rebased on git master]
>> Signed-off-by: Sascha Silbe<silbe at activitycentral.com>
>> ---
>> Just installed Backup [1] on an XO-1 running Sugar 0.82.1 using a
>> bundle without MANIFEST. It installs and starts up fine, no obvious
>> breakage. Dextrose has been shipping this patch for a long time with no
>> reported issues either.
>> 
>> I'm going to push this to master within the next few days.
>> 
>> [1] http://activities.sugarlabs.org/en-US/sugar/addon/4326
> 
> Hi Sascha,
> 
> I have never been a big fan of the MANIFEST myself, so I generally welcome this step.
> 
> I would like the activity authors to comment on the issue, if they see any downsides, critical paths etc. A quick test worked fine for me.

My primary worry is if folks start releasing activities with no MANIFEST will it fail or degrade performance on existing releases out there in the wild, the widespread OLPC build 802 being one I would want to check first. If I remember a past thread from Bernie correctly, it works, but generates a log warning message for every file in the bundle. I need to go test, that thread was quite some time back :)

--G

> Regards,
>   Simon
> 
> 
> About the patch itself, looks good, small nitpick, you should use ' instead of " and I like this pretty-print better:
> 
> diff --git a/src/sugar/activity/bundlebuilder.py b/src/sugar/activity/bundlebuilder.py
> index fdd68ec..462a2b3 100644
> --- a/src/sugar/activity/bundlebuilder.py
> +++ b/src/sugar/activity/bundlebuilder.py
> @@ -278,9 +278,9 @@ def cmd_dist_xo(config, args):
> def cmd_fix_manifest(config, args):
>     '''Add missing files to the manifest (OBSOLETE)'''
> 
> -    print "WARNING: the fix_manifest command is obsolete"
> -    print "the MANIFEST file is no longer used in bundles, please remove it"
> -    pass
> +    print 'WARNING: the fix_manifest command is obsolete.'
> +    print '         The MANIFEST file is no longer used in bundles,'
> +    print '         please remove it.'
> 
> 
> 
> 
>