[Sugar-devel] Fwd: Sugar Labs Bug: 2485

[Jordan Homan]

> From: Jordan Homan <j.homan at me.com>
> Date: February 21, 2011 3:36:16 PM EST
> To: Walter Bender <walter.bender at gmail.com>
> Cc: flux-capacitors462 at googlegroups.com
> Subject: Re: [Sugar-devel] Sugar Labs Bug: 2485
> 

> Hi,
> 
> Thank you for all of your input.  We've taken everyone's input into account when trying to address the bug, and I think we've come up with a reasonable solution.  Here's what we've done:
> 
> 1.  When the user initially creates an account, the changes simply just trim any spaces on the left or right.  If they wish to change their name to multiple lines later, they can do so by editing their name.
> 
> 2.  When the user edits their name, we've implemented a check for the newline character.  If the user has a newline character anywhere in the name, the name will not be trimmed.  If the user does not have a newline character, then any whitespace will still be trimmed off.
> 
> I've attached the files in this email.  Would this be a reasonable solution?  Please let us know if there's something else you would like to see instead.  Thanks for your time.
> 
> Jordan
> 
> On Feb 03, 2011, at 04:02 PM, Walter Bender <walter.bender at gmail.com> wrote:
> 
>> On Thu, Feb 3, 2011 at 3:55 PM, Frederick Grose <fgrose at gmail.com> wrote:
>> > On Thu, Feb 3, 2011 at 3:27 PM, Samuel Greenfeld <greenfeld at laptop.org>
>> > wrote:
>> >>
>> >> Personally I don't think this would break a multi-line fancy name unless
>> >> the desired effect is to override the centering of every line.  How they
>> >> added the extra linefeeds in the middle would be another discussion and
>> >> point we need to know.
>> >>
>> >>
>> >> If we do want to support fancy names, etc., we are going to have to come
>> >> up with ways of testing them to make sure that the rest of the system
>> >> tolerates them.  Names do not always appear alone.
>> >>
>> >>
>> >> In general for non-fancy users, I believe we should try and trim
>> >> whitespace around names, journal entries, etc. because most users likely
>> >> did not mean to add it there .  While one could make fancy names, and
>> >> add leading whitespace to filenames to override sorting as well, this
>> >> actually does violate at least a few file system specs, regardless of
>> >> what shell prompts seem to tolerate.
>> >
>> >
>> > Perhaps Jordan's new team could investigate those implications if they
>> > continue with the proposed change.
>> 
>> I was just about to say the same thing. It could be that we have a
>> means of converting fancy names to safe names for system use, but keep
>> the fancy names for display in the UI... worth investigation by
>> Jordan's team!!
>> 
>> -walter
>> 
>> > Perhaps, as you've suggested, the greatest benefit would be for the new
>> > Learner who unintentionally enters whitespace on their initial registration,
>> > and the proposed strip code should be limited to that event.
>> > Best wishes,
>> >       --Fred
>> > _______________________________________________
>> > Sugar-devel mailing list
>> > Sugar-devel at lists.sugarlabs.org
>> > http://lists.sugarlabs.org/listinfo/sugar-devel
>> >
>> >
>> 
>> 
>> 
>> -- 
>> Walter Bender
>> Sugar Labs
>> http://www.sugarlabs.org
>> _______________________________________________
>> Sugar-devel mailing list
>> Sugar-devel at lists.sugarlabs.org
>> http://lists.sugarlabs.org/listinfo/sugar-devel
> 
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110221/8ba4f241/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: window.py
Type: application/octet-stream
Size: 9230 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110221/8ba4f241/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110221/8ba4f241/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: model.py
Type: application/octet-stream
Size: 4318 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110221/8ba4f241/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110221/8ba4f241/attachment-0002.html>