[Sugar-devel] [PATCH sugar] Fix up style issues introduced by commit 3f8a1e1

Simon Schampijer simon at schampijer.de
Mon Feb 21 15:34:41 EST 2011


On 02/21/2011 03:06 PM, Sascha Silbe wrote:
> Signed-off-by: Sascha Silbe<silbe at activitycentral.com>
> ---
>   extensions/deviceicon/battery.py |   10 +++++-----
>   1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/extensions/deviceicon/battery.py b/extensions/deviceicon/battery.py
> index 0d18a5f..4c1ef37 100644
> --- a/extensions/deviceicon/battery.py
> +++ b/extensions/deviceicon/battery.py
> @@ -191,7 +191,7 @@ class DeviceModel(gobject.GObject):
>
>       def _fetch_properties_from_upower(self):
>           """Get current values from UPower."""
> -        # pylint: disable-msg=W0201
> +        # pylint: disable=W0201
>           try:
>               dbus_props = self._battery_props_iface.GetAll(_UP_DEVICE_IFACE)
>           except dbus.DBusException:
> @@ -250,8 +250,8 @@ def setup(tray):
>       upower = dbus.Interface(up_proxy, 'org.freedesktop.UPower')
>
>       for device_path in upower.EnumerateDevices():
> -        battery = bus.get_object('org.freedesktop.UPower', device_path)
> -        batt_prop_iface = dbus.Interface(battery, dbus.PROPERTIES_IFACE)
> -        device_type = batt_prop_iface.Get(_UP_DEVICE_IFACE, 'Type')
> +        device = bus.get_object('org.freedesktop.UPower', device_path)
> +        device_prop_iface = dbus.Interface(device, dbus.PROPERTIES_IFACE)
> +        device_type = device_prop_iface.Get(_UP_DEVICE_IFACE, 'Type')
>           if device_type == _UP_TYPE_BATTERY:
> -            tray.add_device(DeviceView(battery))
> +            tray.add_device(DeviceView(device))

All good - thanks - go for it!
Simon


More information about the Sugar-devel mailing list