[Sugar-devel] [PATCH v2] Free space displayed for Journal Button in Volumes Toolbar. (Ticket #2318)

Sascha Silbe sascha-ml-reply-to-2011-2 at silbe.org
Sat Feb 12 07:41:09 EST 2011


Excerpts from Ishan Bansal's message of Sun Oct 17 20:44:59 +0200 2010:

> Pallete added to calculate and display free journal space when we write click.

Pushed (with a different description) as 8e59b30 [1], thanks!

I tried refactoring this to use jarabe.views.palettes.JournalPalette,
but the latter builds on jarabe.views.palettes.BasePalette which
requires a HomeActivity instance to work. Since
jarabe.journal.JournalButton is added during Journal initialisation,
a HomeActivity instance (which is basically a wrapper around a mapped
window in our window manager code) is not available.

I'm not perfectly happy with the code duplication, but we can revisit
this when we slim out our window manager code.

Sascha

[1] http://git.sugarlabs.org/sugar/mainline/commit/8e59b300caeff8fee61eb8e586ef54ad64cdf0f1
-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 494 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110212/f9a29512/attachment.pgp>


More information about the Sugar-devel mailing list