[Sugar-devel] [Dextrose] [PATCH sugar 2/2] Send XO serial numbers with anonymous reports

[David Farning]

On Fri, Feb 4, 2011 at 9:05 AM, Aleksey Lim <alsroot at activitycentral.org> wrote:
> On Fri, Feb 04, 2011 at 08:35:03AM -0500, Walter Bender wrote:
>> It is not clear from this patch if there is a way for a deployment (or
>> individual) to disable this feature. It is unprecedented that we have
>> this level of auto-association between user and some arbitrary
>> authority -- there should be an opt-in policy at the deployment level
>> and an opt-out policy at the individual level IMHO.
>
> Actually we don't have implicit separtion between upstrem and downstream
> gconf configs, except having upstream and downstreamstream git repos.
> This feature was implemented entirely only within dextrose (thus mostly
> for deployment needs). It needs to be wteaked to make it vlaid for
> upstream, ie, broad usage.
>
> In case of sendind s/n w/ anonymous submits, it is request from the
> dextrose deployment (local policy permit such things and it might be
> useful for deployment).

This is an excellent answer.  This is going to be a case where Sugar
Labs and Activity Central can complement each other.  Tools like this
are probably not appropriate for Upstream project such as Sugar.  They
are required by deployments.

Activity Central can work with specif deployments who require this
type of ability. Activity Central can work the deployment to ensure
that they are following all local regulations.

david


>> -walter
>>
>> On Thu, Feb 3, 2011 at 3:29 PM, Aleksey Lim <alsroot at member.fsf.org> wrote:
>> > ---
>> >  data/sugar.schemas.in                  |   11 +++++++++++
>> >  src/jarabe/model/feedback_collector.py |   10 ++++++++--
>> >  2 files changed, 19 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/data/sugar.schemas.in b/data/sugar.schemas.in
>> > index 7e4a923..c3606f2 100644
>> > --- a/data/sugar.schemas.in
>> > +++ b/data/sugar.schemas.in
>> > @@ -24,6 +24,17 @@
>> >       </locale>
>> >     </schema>
>> >     <schema>
>> > +      <key>/schemas/desktop/sugar/feedback/anonymous_with_sn</key>
>> > +      <applyto>/desktop/sugar/feedback/anonymous_with_sn</applyto>
>> > +      <owner>sugar</owner>
>> > +      <type>bool</type>
>> > +      <default>false</default>
>> > +      <locale name="C">
>> > +        <short>Add XO serial numbers to anonymous submits</short>
>> > +        <long>Add XO serial numbers to anonymous submits.</long>
>> > +      </locale>
>> > +    </schema>
>> > +    <schema>
>> >       <key>/schemas/desktop/sugar/feedback/server_host</key>
>> >       <applyto>/desktop/sugar/feedback/server_host</applyto>
>> >       <owner>sugar</owner>
>> > diff --git a/src/jarabe/model/feedback_collector.py b/src/jarabe/model/feedback_collector.py
>> > index c0deae2..4671437 100644
>> > --- a/src/jarabe/model/feedback_collector.py
>> > +++ b/src/jarabe/model/feedback_collector.py
>> > @@ -47,7 +47,7 @@ def start(host, port, auto_submit_delay):
>> >     _port = port
>> >
>> >     if auto_submit_delay > 0:
>> > -        gobject.timeout_add_seconds(auto_submit_delay, _submit)
>> > +        gobject.timeout_add_seconds(auto_submit_delay, anonymous_submit)
>> >
>> >
>> >  def update(bundle_id, report, log_file):
>> > @@ -90,7 +90,13 @@ def submit(message):
>> >
>> >
>> >  def anonymous_submit():
>> > -    _submit()
>> > +    from jarabe.journal import misc
>> > +
>> > +    data = {}
>> > +    client = gconf.client_get_default()
>> > +    if client.get_bool('/desktop/sugar/feedback/anonymous_with_sn'):
>> > +        data['serial_number'] = misc.get_xo_serial()
>> > +    _submit(data)
>> >
>> >
>> >  def _submit(data=None):
>> > --
>> > 1.7.3.4
>> >
>> > _______________________________________________
>> > Dextrose mailing list
>> > Dextrose at lists.sugarlabs.org
>> > http://lists.sugarlabs.org/listinfo/dextrose
>> >
>>
>>
>>
>> --
>> Walter Bender
>> Sugar Labs
>> http://www.sugarlabs.org
>>
>
> --
> Aleksey
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>