[Sugar-devel] [PATCH] Modify search icon to honor stroke and fill color

[Gonzalo Odiard]

On Thu, Feb 3, 2011 at 4:26 PM, Simon Schampijer <simon at schampijer.de>wrote:

> Hi Gonzalo,
>
> looks good to me. Please push to the master branch.
>

I think you added to Gonzalo Delgado, not me.
I am godiard in git.


>
> From the icons under icons/scalable/actions the logout icon does not honour
> the stroke and fill colour - I would take a patch for that one, too :)
>
> All this icons don't have the entities defined:

cell-format.svg
cell-height.svg
cell-size.svg
cell-width.svg
column-insert.svg
column-remove.svg
edit-redo.svg
edit-undo.svg
format-columns-double.svg
format-columns-single.svg
format-columns-triple.svg
format-justify-center.svg
format-justify-fill.svg
format-justify-left.svg
format-justify-right.svg
format-text-bold.svg
format-text-italic.svg
format-text-leading.svg
format-text-size.svg
format-text-underline.svg
go-next-paired.svg
go-previous-paired.svg
insert-image.svg
insert-table.svg
invite.svg
row-insert.svg
row-remove.svg
system-logout.svg
toolbar-colors.svg
tray-hide.svg
tray-show.svg
view-refresh.svg
zoom-best-fit.svg
zoom-in.svg
zoom-out.svg

To get the list i did:

[gonzalo at aronax actions]$ ls *.svg | sort > /tmp/all_icons.txt
[gonzalo at aronax actions]$ grep "ENTITY stroke_color" *.svg | awk -F":"
'{printf("%s\n", $1)}' | sort > /tmp/icons_with_entities.txt
[gonzalo at aronax actions]$ diff -u /tmp/icons_with_entities.txt
/tmp/all_icons.txt | grep "+" | grep -v "@"

I have created a ticket http://dev.laptop.org/ticket/10663 to follow this.

Gonzalo

OT: checking the existing tickets I found http://dev.laptop.org/ticket/8612,
I think must be closed


> On 02/03/2011 06:05 PM, godiard at sugarlabs.org wrote:
>
>> From: Gonzalo Odiard<godiard at gmail.com>
>>
>> ---
>>  icons/scalable/actions/system-search.svg |    9 ++++++---
>>  1 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/icons/scalable/actions/system-search.svg
>> b/icons/scalable/actions/system-search.svg
>> index 7b19fe5..f132175 100644
>> --- a/icons/scalable/actions/system-search.svg
>> +++ b/icons/scalable/actions/system-search.svg
>> @@ -1,11 +1,14 @@
>>  <?xml version="1.0" encoding="utf-8"?>
>>  <!-- Generator: Adobe Illustrator 13.0.2, SVG Export Plug-In . SVG
>> Version: 6.00 Build 14948)  -->
>> -<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "
>> http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
>> +<!DOCTYPE svg  PUBLIC '-//W3C//DTD SVG 1.1//EN'  '
>> http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd' [
>> +<!ENTITY stroke_color "#010101">
>> +<!ENTITY fill_color "#FFFFFF">
>> +]>
>>  <svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg"
>> xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
>>         width="22.156px" height="22.156px" viewBox="0 0 22.156 22.156"
>> enable-background="new 0 0 22.156 22.156" xml:space="preserve">
>>  <g>
>> -       <path fill="none" stroke="#4C4D4F" stroke-width="3.5"
>> d="M1.75,9.216c0,4.125,3.342,7.47,7.468,7.47
>> +       <path fill="none" stroke="&fill_color;" stroke-width="2"
>> d="M1.75,9.216c0,4.125,3.342,7.47,7.468,7.47
>>
>>  c4.121,0,7.466-3.345,7.466-7.47c0-4.123-3.345-7.466-7.466-7.466C5.092,1.75,1.75,5.093,1.75,9.216z"/>
>> -       <line fill="none" stroke="#4C4D4F" stroke-width="3.5" x1="14.498"
>> y1="14.497" x2="20.918" y2="20.919"/>
>> +       <line fill="none" stroke="&fill_color;" stroke-width="2"
>> x1="14.498" y1="14.497" x2="20.918" y2="20.919"/>
>>  </g>
>>  </svg>
>>
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110204/a5a4e27d/attachment-0001.html>