[Sugar-devel] [PATCH] Implement filter in favorites view - v3

[Gary Martin]

Hi Simon,

On 19 Aug 2011, at 09:31, Simon Schampijer wrote:

> On 08/19/2011 04:33 AM, godiard at sugarlabs.org wrote:
>> From: Gonzalo Odiard<godiard at gmail.com>
>> 
>> After evaluation with Design Team, the filter higlight selected
>> activities applying a alpha of 0.33 in the unselected activities.
>> This patch add strip() to the query to avoid accidental filtering
>> of all activities by adding spaces.
>> 
>> Signed-off-by: Gonzalo Odiard<gonzalo at laptop.org>
> 
> Thanks pushed as is:
> 
> http://git.sugarlabs.org/sugar/mainline/commit/cf6675fc21abf97ca09408d2a13b6913fa1559d7
> 
> I would like the filter constant to be factored out in the future since we use it in several places now. I guess sugar/style.py is a good place.
> 
> Regards,
>   Simon
> 
> PS: In general I think the alpha value is too high here. The difference between a filtered and an unfiltered value is not enough (the 0.33 value works well for the launcher though). I had better experience with a value of 0.15 for example.

Understood. OK so we have a suggested range so far of 0.15, 0.2, and 0.33, I think a fair chunk of this will be down to variation in display physical characteristics, gamma, ect,  for the displays we have tested on. I wonder if we can (or want to) get into adjusting such parameters based on the display characteristics. Perhaps we could go with the mean value of 0.23 to split the difference (and/or wait for some more feedback to see what the wider community thinks once they have seen it in action)?

Regards,
--Gary

> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel