[Sugar-devel] [PATCH sugar-toolkit] Replace our custom entry widget with one based on gtk.Entry

[Simon Schampijer]

On 08/11/2011 06:27 PM, Benjamin Berg wrote:
> On Wed, 2011-08-10 at 14:31 +0200, simon at schampijer.de wrote:
>> Our custom entry widget, which was based on sexyicon, did
>> support placing an icon in the entry (e.g. the magnifier icon
>> for the search entry) and displaying progress in the case of
>> the url entry in Browse. Both is supported since GTK+ 2.16 in the
>> gtk.Entry.
>>
>> The patch does keep the old API, that is why we can land it in
>> 0.94 no change in the shell needed only a small change in Browse,
>> in a second step I would like to use the upstream API e.g.
>> 's/set_icon_from_name/set_icon_from_icon_name'.
>>
>> Signed-off-by: Simon Schampijer<simon at laptop.org>
> Reviewed-by: Benjamin Berg<benzea at sugarlabs.org>
>
> Nice to have so much code removed :-)
>
> Fine with me. There are some slight API changes, but it seems nobody was
> using this API.
>
> Benjamin

Thanks for the review!

Yes, I made sure no activity nor the shell is using the set_icon method 
(where we pass the pixbuf now) and furthermore we raise an exception if 
does.

Pushed as: 
http://git.sugarlabs.org/sugar-toolkit/mainline/commit/17ec110798a53110c4952181f92b9ab8d3da1337

Regards,
    Simon