[Sugar-devel] [PATCH sugar-toolkit] Replace our custom entry widget with one based on gtk.Entry

Benjamin Berg benzea at sugarlabs.org
Thu Aug 11 12:27:21 EDT 2011


On Wed, 2011-08-10 at 14:31 +0200, simon at schampijer.de wrote:
> Our custom entry widget, which was based on sexyicon, did
> support placing an icon in the entry (e.g. the magnifier icon
> for the search entry) and displaying progress in the case of
> the url entry in Browse. Both is supported since GTK+ 2.16 in the
> gtk.Entry.
> 
> The patch does keep the old API, that is why we can land it in
> 0.94 no change in the shell needed only a small change in Browse,
> in a second step I would like to use the upstream API e.g.
> 's/set_icon_from_name/set_icon_from_icon_name'.
> 
> Signed-off-by: Simon Schampijer <simon at laptop.org>
Reviewed-by: Benjamin Berg <benzea at sugarlabs.org>

Nice to have so much code removed :-)

Fine with me. There are some slight API changes, but it seems nobody was
using this API.

Benjamin



More information about the Sugar-devel mailing list