[Sugar-devel] [PATCH] revise timezone list, #2195

[James Cameron]

On Sun, Apr 03, 2011 at 01:42:49PM +0200, Sascha Silbe wrote:
> Excerpts from James Cameron's message of Wed Mar 23 00:58:09 +0100 2011:
> 
> > Yes, the system will claim the local time zone to be UTC.  This is
> > unchanged from before the patch.  The patch was not intended to fix
> > this.  Do you consider it a problem?  It is not mentioned in #2195.
> > Would you like a bug raised in trac?  It will only affect applications
> > or activites that use TZ, and I don't have a list of those.  I cannot
> > assess the impact.
> 
> Your last sentence highlights the issue: We're going from obviously
> incorrect to partially incorrect and I can't tell what the effects of
> the partial incorrectness will be.

Partial incorrectness is adequate, and better than obviously incorrect.

If maintainers are unwilling to move from obviously incorrect to
partially incorrect, then my patch should be refused.

> My immediate thought would be to just drop the additional, offset
> based time zones. What exactly is the use case for these? If it's just
> time zones that are missing from distributions, we should work on
> getting them included upstream and patch either Sugar or the
> distribution packages to include them in the meantime.
> 
> Other options, depending on the use case, might be:
> 
> 1. Add time zones in /usr/share/zoneinfo/Etc to the list.
> 2. Turn the list into a ComboBoxEntry so users can enter arbitrary time
>    zone values (in standard or implementation-defined format).
> 3. Tell users to directly manipulate the gconf setting
>    (/desktop/sugar/date/timezone).
> 
> In any case, we should fix the code to either look up the standard
> format for the chosen time zone or prefix the location name with a
> colon.

I find the issue no longer interesting, sorry.  I don't believe it
justifies the investment in further discussion at this level of detail.

-- 
James Cameron
http://quozl.linux.org.au/