[Sugar-devel] [PATCH v2 Calculate] Changed symbols on the calculate activity button. (Ticket #2161)

Sascha Silbe sascha-ml-reply-to-2010-3 at silbe.org
Thu Sep 30 14:45:04 EDT 2010

Excerpts from Ishan Bansal's message of Thu Sep 30 18:58:06 +0200 2010:

> New symbols "×", "÷" and "=" (instead of "*","/" and "Enter" respectively)
> defined for the calculator activity in order to give a calculator look to
> activity.

No need to mention "the calculator activity" as there's nothing else in
this repository.
Please adjust the summary as well.

> v1 was Reviewed-By Sascha Silbe <sascha-ml-reply-to-2010-3 at silbe.org>

Not really. I reviewed it, but since there were things I wanted to be
changed, I did not "grant" my Reviewed-By: tag. The meaning of that
tag is that I reviewed the patch _and_ believe it to be fit for
inclusion, standing with my reputation behind that judgement (see [1],
section 14).

> v1->v2: Symbol for "x" changed to "×"and bug description changed.


> -            [3, 3, 3, _('Enter'), self.col_gray1, lambda w: self._parent.process()],
> +            [3, 3, 3, ('='), self.col_gray1, lambda w: self._parent.process()],

I just noticed (see below) that we translate the other symbols, so we
should do the same for =. Since I don't know whether there's a reason
for using names (mul_sym / div_sym) instead of the symbols (previously
* and /) for translation, we should use a name for '=' just to be on the
safe side. So please translate '=' the same way the multiplication and
division symbols are translated.

>          # TRANS: multiplication symbol (default: '*')
>          self.mul_sym = _('mul_sym')
>          # TRANS: division symbol (default: '/')
>          self.div_sym = _('div_sym')

Ah, it always pays to give things a second look. ;)
Please adjust these comments as well.


[1] http://www.kernel.org/doc/Documentation/SubmittingPatches
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100930/4336e086/attachment.pgp 

More information about the Sugar-devel mailing list