[Sugar-devel] [PATCH v3 sugar] Work around for fullscreen bug (SL #2180)

Tomeu Vizoso tomeu at sugarlabs.org
Mon Sep 27 10:59:37 EDT 2010


On Mon, Sep 27, 2010 at 16:48, Dipankar Patro <dipankar at seeta.in> wrote:
> Previously some bottom part of sugar emulator window was pushed out of viewing area at 800x600 system resolution.
> The patch opens Sugar-emulator in fullscreen mode for resolutions <= 800x600 to avoid the above mentioned situation.

I meant changing the _Subject_ line of the patch describe what the
patch does in less than 80 chars. Sometimes is hard but is very
important to try.

Right now it is:

Subject: [Sugar-devel] [PATCH v3 sugar] Work around for fullscreen bug
(SL #2180)

I'm saying this because often when going through the history people
will only see the subject line.

Thanks,

Tomeu

> ---
>  src/jarabe/util/emulator.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> v2 was Reviewed by Tomeu Vizoso
> v2->v3 : Changed commit message for proper description of patch.
>
> diff --git a/src/jarabe/util/emulator.py b/src/jarabe/util/emulator.py
> index 6a43044..cc112c9 100644
> --- a/src/jarabe/util/emulator.py
> +++ b/src/jarabe/util/emulator.py
> @@ -42,7 +42,7 @@ def _run_xephyr(display, dpi, dimensions, fullscreen):
>     screen_size = (gtk.gdk.screen_width(), gtk.gdk.screen_height())
>
>     if (not dimensions) and (fullscreen is None) and \
> -       (screen_size < default_dimensions) :
> +       (screen_size <= default_dimensions) :
>         # no forced settings, screen too small => fit screen
>         fullscreen = True
>     elif (not dimensions) :
> --
> 1.7.0.4
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>


More information about the Sugar-devel mailing list