[Sugar-devel] SL bug #1520

[Tomeu Vizoso]

On Wed, Sep 22, 2010 at 09:50, Tomeu Vizoso <tomeu at sugarlabs.org> wrote:
> On Tue, Sep 21, 2010 at 20:50, Sascha Silbe
> <sascha-ml-reply-to-2010-3 at silbe.org> wrote:
>> Excerpts from Mukul Gupta's message of Tue Sep 21 20:06:11 +0200 2010:
>>
>>> I had a word with Bernie regarding the issue and he says that probably newer
>>> versions of the X server actually implement XUngrabKey() with keycode= Any
>>> Key as specified in the man-page. He said he had seen the source code and
>>> someone (whot) reworked that function sometime back, probably fixing up the
>>> bug.
>>
>> What component (package) is that in and which version fixed it? Or which
>> source file and function contains the change so I can try scanning the
>> repo?
>
> The most relevant changes I have found are:
>
> commit ff1d6244eba8367a8d50601ca393e951c60c94b6
> Author: Peter Hutterer <peter.hutterer at who-t.net>
> Date:   Mon Jun 1 12:14:52 2009 +1000
>
>    input: add support for XIAnyModifier in passive XI2 grabs.
>
> commit 80ea32ad4f1440d068e18db65830f45498703b09
> Author: Peter Hutterer <peter.hutterer at who-t.net>
> Date:   Mon Jun 1 12:06:55 2009 +1000
>
>    dix: switch grab checking from unsigned shorts to unsigned ints
>
>    XIAnyModifier is outside of the unsigned short range.
>
>    Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Btw, we should be logging such findings about bugs in a bug tracker.
Otherwise we end up digging again where others dug in the past.

Regards,

Tomeu

> Regards,
>
> Tomeu
>
>> Sascha
>>
>> --
>> http://sascha.silbe.org/
>> http://www.infra-silbe.de/
>>
>> _______________________________________________
>> Sugar-devel mailing list
>> Sugar-devel at lists.sugarlabs.org
>> http://lists.sugarlabs.org/listinfo/sugar-devel
>>
>>
>