[Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349

[Tomeu Vizoso]

Hi,

I'm proposing this patch for inclusion in master during the hard code
freeze period as per
http://wiki.sugarlabs.org/go/0.90/Roadmap#Schedule

The benefit is a more consistent neighborhood view and the risk is very low.

Thanks,

Tomeu

On Mon, Sep 20, 2010 at 14:56, Tomeu Vizoso
<tomeu.vizoso at collabora.co.uk> wrote:
> ---
>  src/jarabe/model/neighborhood.py |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/src/jarabe/model/neighborhood.py b/src/jarabe/model/neighborhood.py
> index 76a0a7d..9d82db3 100644
> --- a/src/jarabe/model/neighborhood.py
> +++ b/src/jarabe/model/neighborhood.py
> @@ -387,8 +387,9 @@ class _Account(gobject.GObject):
>             if handle in self._buddy_handles:
>                 presence_type, status_, message_ = presence
>                 if presence_type == CONNECTION_PRESENCE_TYPE_OFFLINE:
> +                    contact_id = self._buddy_handles[handle]
>                     del self._buddy_handles[handle]
> -                    self.emit('buddy-removed', handle)
> +                    self.emit('buddy-removed', contact_id)
>
>     def __buddy_info_updated_cb(self, handle, properties):
>         logging.debug('_Account.__buddy_info_updated_cb %r', handle)
> --
> 1.7.2.3
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>