[Sugar-devel] [PATCH] [PATCH] Shutdown and Logout menu items should activate the buzzy cursor (SL#2151)

Sascha Silbe sascha-ml-reply-to-2010-3 at silbe.org
Sun Sep 19 15:36:33 EDT 2010


Excerpts from Anurag Chowdhury's message of Sun Sep 19 19:51:02 +0200 2010:

> Shutdown (and Logout) menu items should activate the buzzy cursor (or provide some other visual feedback, perhaps dimming/locking the UI from use).

It's called a "busy cursor" [1] because it indicates that the computer
is currently busy, not because it buzzes around. ;)
Please wrap lines in the patch description so they are no longer that 80
characters ([2] hints at it in section 15).
The subject is fine in general (except for the double [PATCH] and buzzy
vs. busy), though I would express it in a more active way: Use busy
cursor during shutdown and logout.

> +        self.window.get_window(set_cursor( gtk.gdk.Cursor(gtk.gdk.WATCH)))

Please run pep8 [3] and fix anything you introduced.

Sascha

[1] http://www.freedesktop.org/wiki/Specifications/cursor-spec
[2] https://www.kernel.org/doc/Documentation/SubmittingPatches
[3] https://wiki.sugarlabs.org/go/Development_Team/Code_guidelines#Tools
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100919/4de85a2e/attachment.pgp 


More information about the Sugar-devel mailing list