[Sugar-devel] [PATCH sugar-0.84] journal scan of external media

[Sascha Silbe]

Excerpts from James Cameron's message of Mon Sep 13 11:19:07 +0200 2010:

> > Ah, don't you love how undefined behaviour still affects performance?
> 
> I think that's quite expected, especially since performance is equally
> undefined.  Although the order may not be defined, there is likely to be
> an ordering imposed by the underlying implementation.

OK, good point.

> Repeated test on Sugar 0.84 with my set of working and broken devices.
> The following diff is proposed for final review.

After staring at it for about half an hour, I couldn't find anything to
reasonably nag about.

Reviewed-By: Sascha Silbe <sascha-pgp at silbe.org>

If you'd like, you could replace your "pending" lists with
collections.deque which is supposed to be suited better to your use
case, especially for the .pop(0).
I'd expect the scanning to be IO-bound in most cases, so keeping the
lists should be acceptable (if you don't want to retest with the deque).

Thanks!

Sascha

--
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100913/5753f041/attachment.pgp