[Sugar-devel] [PATCH] Added Protected-Activities-Support to sugar (SL#2087)

Daniel Drake dsd at laptop.org
Wed Sep 8 15:34:33 EDT 2010


On 8 September 2010 11:13, Kandarp Kaushik <kandarp at seeta.in> wrote:
> This patch provides a mechanism that uses a gconf value to determine
> which activities will not contain the erase option at the list view
> palette. The gconf value contains a list of activities bundle indentifiers.

Your efforts to help move tickets along are appreciated but you are
adding disruption to the process.

Where a review process has started on trac, please keep the patch
reviews on trac.
(sending an email with a link to the ticket, requesting on-trac review
is of course acceptable and a good idea where review has stalled)

In this case we have multiple people working on the same bug with
different versions of the same patch being submitted in 2 different
places on the same day.

You have also erased authorship information which is not a very nice
gesture to the original developer.

To reviewers: my suggestion is to ignore the patch in this thread,
review the latest version of the patch on trac:
http://bugs.sugarlabs.org/ticket/2087
The one on trac incorporates feedback from the design team, is a tiny
bit cleaner, and retains correct authorship information.

Daniel


More information about the Sugar-devel mailing list